BUG 18505: opac-search-history does not respect opacPublic
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 28 Apr 2017 07:48:50 +0000 (08:48 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Mon, 8 May 2017 14:16:20 +0000 (10:16 -0400)
The opac-search-history page was available regardless of the opacPublic setting, this
patch corrects that.

Test plan, set opacPublic to 'No', test whether opac-search-history page is available
when not logged in, note that it is.
Apply patch, test whether opac-search-history is still available when not logged in,
note that you should be redirected to the login page.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

opac/opac-search-history.pl

index 34b0e84..da1196b 100755 (executable)
@@ -40,7 +40,7 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user(
         template_name => "opac-search-history.tt",
         query => $cgi,
         type => "opac",
-        authnotrequired => 1,
+        authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
         flagsrequired => {borrowers => 1},
         debug => 1,
     }