Bug 25239: Fix semantic heading for opac-reserve.tt
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 11 Jun 2020 12:05:31 +0000 (13:05 +0100)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Sun, 26 Jul 2020 14:31:59 +0000 (16:31 +0200)
Prior to this patch, the opac-reserve contained semantically incorrect headings.

Test plan
1/ Perform a search which yields some results in the OPAC
2/ Attempt to place a hold on an item.
3/ On the resulting screen, note that the headings are:
   H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels)
4/ Apply this patch and reload the page
5/ Re-inspect the elements in question note the heading semantics are now:
   H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels)
6/ Note the appearance of the box is still reasonable
7/ Signoff

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1a96ede5f114bd90fe1735702ca4bab77dfed9d4)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 5574a5850f2a55a3544b3f9d5c95bf491aae4e03)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

(cherry picked from commit 94688f92512cb69812f558b74e283f0ae585dfea)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt

index ba68f0e..f96dd5f 100644 (file)
 
             [% UNLESS ( message ) %]
                 [% UNLESS ( none_available ) %]
-                    <h3>Confirm holds for:[% INCLUDE 'patron-title.inc' patron = logged_in_user %] ([% logged_in_user.cardnumber | html %])</h3>
+                    <h2>Confirm holds for:[% INCLUDE 'patron-title.inc' patron = logged_in_user %] ([% logged_in_user.cardnumber | html %])</h2>
                 [% END # / UNLESS none_available %]
 
                 [% IF (RESERVE_CHARGE) %]