Bug 21671: Prevent Modifications.t to fail randomly

If repeatable is set to 0 by TestBuilder, the tests will fail with:
t/db_dependent/Koha/Patron/Modifications.t .. 1/6     # Looks like you planned 20 tests but ran 9.

 #   Failed test 'approve tests'
 #   at t/db_dependent/Koha/Patron/Modifications.t line 259.
[repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 914f23970de536df3972ebd75b280ee8eec98955)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 3f99fb0c4c8b85285cd7b22d77d8d15cadda5098)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

diff --git a/t/db_dependent/Koha/Patron/Modifications.t b/t/db_dependent/Koha/Patron/Modifications.t
index 1888088..decd9ac 100755 (executable)
--- a/t/db_dependent/Koha/Patron/Modifications.t
+++ b/t/db_dependent/Koha/Patron/Modifications.t
@@ -146,7 +146,7 @@ subtest 'approve tests' => sub {
         { source => 'BorrowerAttributeType', value => { code => 'CODE_1' } }
     );
     $builder->build(
-        { source => 'BorrowerAttributeType', value => { code => 'CODE_2' } }
+        { source => 'BorrowerAttributeType', value => { code => 'CODE_2', repeatable => 1 } }
     );
     my $verification_token = md5_hex( time().{}.rand().{}.$$ );
     my $valid_json_text