Bug 22066: Record library_id for manual credits
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 7 Jan 2019 17:06:01 +0000 (14:06 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 1 Feb 2019 12:31:33 +0000 (12:31 +0000)
On creating manual credits, the (newly introduced) branchcode should be
set now. This trivial patch makes it work.

To test:
- Create a manual credit for a known patron
- Using MySQL check the result:
  $ sudo mysql
  > SELECT * FROM accountlines WHERE borrowernumber=<known_id>;
=> FAIL: The created accountline row has NULL for the branchcode
- Apply this patch
- Create a manual credit for the patron
- Run:
  > SELECT * FROM accountlines WHERE borrowernumber=<known_id>;
=> SUCCESS: branchcode is set correctly
-Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 094a1cb0703b22d18c061cdc4879c1fc3c76ea80)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

members/mancredit.pl

index 6da0fe2..014d822 100755 (executable)
@@ -81,10 +81,13 @@ if ($add){
     my $amount      = $input->param('amount') || 0;
     my $type        = $input->param('type');
 
+    my $library_id = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
+
     $patron->account->add_credit({
         amount      => $amount,
         description => $description,
         item_id     => $item_id,
+        library_id  => $library_id,
         note        => $note,
         type        => $type,
         user_id     => $logged_in_user->id