Bug 23463: Replace SearchItemsByField by SearchItems

The subroutine SearchItemsByField is only called once and can be
replaced easily with SearchItems

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/acqui/check_uniqueness.pl b/acqui/check_uniqueness.pl
index 70d95dd..8b36e68 100755 (executable)
--- a/acqui/check_uniqueness.pl
+++ b/acqui/check_uniqueness.pl
@@ -43,7 +43,7 @@ my @value = $input->multi_param('value[]');
 my $r = {};
 my $i = 0;
 for ( my $i=0; $i<@field; $i++ ) {
-    my $items = C4::Items::SearchItemsByField($field[$i], $value[$i]);
+    my ($items) = C4::Items::SearchItems({ field => $field[$i], query => $value[$i]});
 
     if ( @$items ) {
         push @{ $r->{$field[$i]} }, $value[$i];

diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t
index da4b6f0..981fa86 100755 (executable)
--- a/t/db_dependent/Items.t
+++ b/t/db_dependent/Items.t
@@ -439,7 +439,7 @@ subtest 'SearchItems test' => sub {
     });
 
     t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
-    my $cpl_items_before = SearchItemsByField( 'homebranch', $library1->{branchcode});
+    my ($cpl_items_before) = SearchItems( { field => 'homebranch', query => $library1->{branchcode} } );
 
     my $biblio = $builder->build_sample_biblio({ title => 'Silence in the library' });
     $builder->build_sample_biblio({ title => 'Silence in the shadow' });
@@ -595,8 +595,8 @@ subtest 'SearchItems test' => sub {
     ($items, $total_results) = SearchItems($filter);
     ok(scalar @$items == 1, 'found 1 item with itemnotes = "foobar"');
 
-    my $cpl_items_after = SearchItemsByField( 'homebranch', $library1->{branchcode});
-    is( ( scalar( @$cpl_items_after ) - scalar ( @$cpl_items_before ) ), 1, 'SearchItemsByField should return something' );
+    my ($cpl_items_after) = SearchItems( { field => 'homebranch', query => $library1->{branchcode} } );
+    is( ( scalar( @$cpl_items_after ) - scalar ( @$cpl_items_before ) ), 1, 'SearchItems should return something' );
 
     # Issues count may be NULL
     $filter = {