Bug 22812: Fix new subscription with strict sql modes
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 6 May 2019 18:34:19 +0000 (13:34 -0500)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 24 May 2019 13:49:43 +0000 (14:49 +0100)
With sql_strict_modes turned on, if you try to create a new subscription
you will get:
Incorrect integer value: '' for column '$INT_COLUMN' at row 1

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit e8e7ea352ef237555ee4d47c98feb879f3eb9e31)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

C4/Serials.pm

index 91498ee..7f722f4 100644 (file)
@@ -1371,6 +1371,11 @@ sub NewSubscription {
     ) = @_;
     my $dbh = C4::Context->dbh;
 
+    $_ ||= undef # Set to undef for integer values, not empty string
+      for (
+        $aqbooksellerid, $lastvalue1, $innerloop1, $lastvalue2,
+        $innerloop2,     $lastvalue3, $innerloop3,
+      );
     #save subscription (insert into database)
     my $query = qq|
         INSERT INTO subscription