Bug 22059: Fix exception params in Koha::Patron->set_password
authorTomas Cohen Arazi <tomascohen@theke.io>
Wed, 2 Jan 2019 12:56:52 +0000 (09:56 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 10 Jan 2019 13:25:15 +0000 (13:25 +0000)
This simple patch fixes a wrong call to ->throw. Parameters shouldn't be
enclosed in curly brackets.

To test:
- Apply the tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail because the throw call is wrong
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass!
-Sign off :-D

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 4d671103f420f1c0b80bcbf13be613b69e2aa4f9)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Koha/Patron.pm

index 5831034..3a079f6 100644 (file)
@@ -703,7 +703,7 @@ sub set_password {
 
             my $password_length = length($password);
             Koha::Exceptions::Password::TooShort->throw(
-                { length => $password_length, min_length => $min_length } );
+                length => $password_length, min_length => $min_length );
         }
         elsif ( $error eq 'has_whitespaces' ) {
             Koha::Exceptions::Password::WhitespaceCharacters->throw();