Bug 14781: Creation of barcode types 2of5 not functional
authorMarc Véron <veron@veron.ch>
Fri, 4 Sep 2015 07:50:07 +0000 (09:50 +0200)
committerLiz Rea <wizzyrea@gmail.com>
Wed, 9 Dec 2015 23:19:38 +0000 (12:19 +1300)
This patch fixes the rendering of "COOP2of5" or "Industrial2of5" barcodes in the label creator module.

To test:
- Create a label layout with COOP2of5 barcode type
- Create labels (make sure that the items's barcode values are numeric only!)
- Export batch and download PDF.

Without patch:
- No barcodes rendered
With patch
- Barcodes should render as expected. Test for both barcode types.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works as described, tested both formats.
Non digit barcode is not printed.

No koha-qa errors, no t/ & xt/ errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Note: To be printed, barcode should be numerical.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2b88f0cb38d74da93a723fd1cf3cbcf68030649e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(cherry picked from commit 0d0b4ae8486888a37ab09bd1e8f211c30e43b943)
Signed-off-by: Liz Rea <wizzyrea@gmail.com>

C4/Labels/Label.pm

index 83093a4..7a2cbc4 100644 (file)
@@ -535,7 +535,7 @@ sub barcode {
             PDF::Reuse::Barcode::COOP2of5(
                 x                   => $params{'llx'},
                 y                   => $params{'lly'},
-                value               => "*$params{barcode_data}*",
+                value               => $params{barcode_data},
                 xSize               => $x_scale_factor,
                 ySize               => $params{'y_scale_factor'},
                 mode                    => 'graphic',
@@ -553,7 +553,7 @@ sub barcode {
             PDF::Reuse::Barcode::Industrial2of5(
                 x                   => $params{'llx'},
                 y                   => $params{'lly'},
-                value               => "*$params{barcode_data}*",
+                value               => $params{barcode_data},
                 xSize               => $x_scale_factor,
                 ySize               => $params{'y_scale_factor'},
                 mode                    => 'graphic',