Bug 23070: Increment all priorities in 1 query

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index a78f2a4..2a5904f 100644 (file)
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -2006,10 +2006,8 @@ sub RevertWaitingStatus {
 
     ## Increment the priority of all other non-waiting
     ## reserves for this bib record
-    my $holds = Koha::Holds->search({ biblionumber => $hold->biblionumber, priority => { '>' => 0 } });
-    while ( my $h = $holds->next ) {
-        $h->priority( $h->priority + 1 )->store;
-    }
+    my $holds = Koha::Holds->search({ biblionumber => $hold->biblionumber, priority => { '>' => 0 } })
+                           ->update({ priority => \'priority + 1' });
 
     ## Fix up the currently waiting reserve
     $hold->set(