Bug 14709: Do not access to C4::Context->userenv from the commandline
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 24 Aug 2015 09:07:37 +0000 (10:07 +0100)
committerTomas Cohen Arazi <tomascohen@unc.edu.ar>
Wed, 2 Sep 2015 13:02:33 +0000 (10:02 -0300)
The script dies with
  Can't use an undefined value as a HASH reference at tools/export.pl
line 149.
if it is called from the command line.

This is introduced by bug 13040.

The C4::Context->userenv is not defined in this case.

Test plan:
Execute the script using the command line.
With the patch applies you should not get the error.

Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>

tools/export.pl

index 2191b02..80a15b4 100755 (executable)
@@ -146,7 +146,7 @@ if (   C4::Context->preference("IndependentBranches")
     @branch = ( C4::Context->userenv->{'branch'} );
 }
 # if stripping nonlocal items, use loggedinuser's branch
-my $localbranch = C4::Context->userenv->{'branch'};
+my $localbranch = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
 
 my %branchmap = map { $_ => 1 } @branch; # for quick lookups