Bug 23730: Fix export of reports
authorNick <nick@bywatersolutions.com>
Thu, 3 Oct 2019 13:21:35 +0000 (13:21 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 7 Oct 2019 12:00:17 +0000 (13:00 +0100)
To test:
1 - Run a saved report
2 - Attempt to export results
3 - It fails
4 - Apply patch
5 - It succeeds

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

reports/guided_reports.pl

index bb4e87e..aad0418 100755 (executable)
@@ -888,7 +888,7 @@ elsif ($phase eq 'Export'){
     my $reportname     = $input->param('reportname');
     my $reportfilename = $reportname ? "$reportname-reportresults.$format" : "reportresults.$format" ;
 
-    $sql = get_prepped_report( $sql, \@param_names, \@sql_params );
+    ($sql, undef) = get_prepped_report( $sql, \@param_names, \@sql_params );
        my ($sth, $q_errors) = execute_query($sql);
     unless ($q_errors and @$q_errors) {
         my ( $type, $content );