Bug 25791: Remove win.print()
authorLucas Gass <lucas@bywatersolutions.com>
Wed, 15 Jul 2020 22:28:07 +0000 (22:28 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 24 Aug 2020 08:46:13 +0000 (10:46 +0200)
Test plan:
1) Turn on system preference SelfCheckReceiptPrompt
2) Check out item via /cgi-bin/koha/sco/sco-main.pl
3) Click "Finish"
4) Click 'Print receipt and end session'
5) Notice two print dialog boxes right on top of each other
6) Apply patch
7) Repeat steps 1 - 4
8) Should only get a single print dialog.
9) Test in FF/Chrome and make sure behavior is consistent

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt

index c428886..8a05dd4 100644 (file)
                     confirmModal("", _("Would you like to print a receipt?"), _("Print receipt and end session"), _("End session"), function(result) {
                         if ( result && (Date.now() - confirmStart) < [% SelfCheckTimeout | html %] ) {
                             var win = window.open("/cgi-bin/koha/sco/printslip.pl?borrowernumber=[% borrowernumber | html %]&amp;print=qslip");
-                            win.print();
                             location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout';
                         } else {
                             location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout';