Bug 12913: [QA Follow-up] Reword 'change item status' and add zero status

The zero status should be added in @notforloans. It is a legitimate status
for available books. The zero status description can be translated in
the template.
The 'Change item status' is confusing. We mean that we saw a notforloan
status that we do not expect (read: does not exist in the table).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
index a76fdef..650a510 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt
@@ -177,12 +177,18 @@ $(document).ready(function(){
                               <legend>[% status.fieldname %]</legend>
                               <ul id="statuses-[% fieldname %]" style="display: inline;">
                               [% FOREACH value IN status.values %]
-                                  [% IF (value.lib) %]<li>
+                                  [% IF (value.lib) %]
+                                    <li>
                                     <label for="[% value.id %]">
-                                      [% value.lib %]
+                                        [% IF value.authorised_value==0 %]
+                                            For loan
+                                        [% ELSE %]
+                                            [% value.lib %]
+                                        [% END %]
                                     </label>
                                     <input type="checkbox" name="status-[% status.fieldname %]-[% value.authorised_value %]" id="[% value.authorised_value %]" />
-                                  </li>[% END %]
+                                    </li>
+                                  [% END %]
                               [% END %]
                               </ul>
                           </fieldset>
@@ -293,7 +299,7 @@ $(document).ready(function(){
             [% ELSIF result.problem == 'missingitem' %]
                 <p>Item missing</p>
             [% ELSIF result.problem == 'changestatus' %]
-                <p>Change item status</p>
+                <p>Unknown not-for-loan status</p>
             [% ELSIF result.problem == 'not_scanned' %]
                 <p>Item should have been scanned</p>
             [% END %]

diff --git a/tools/inventory.pl b/tools/inventory.pl
index be57303..731ad77 100755 (executable)
--- a/tools/inventory.pl
+++ b/tools/inventory.pl
@@ -94,11 +94,14 @@ for my $statfield (qw/items.notforloan items.itemlost items.withdrawn items.dama
     $hash->{authcode} = $mss->count ? $mss->next->authorised_value : undef;
     if ($hash->{authcode}){
         my $arr = GetAuthorisedValues($hash->{authcode});
-        $hash->{values} = $arr;
-        push @$statuses, $hash;
         if ( $statfield eq 'items.notforloan') {
+            # Add notforloan == 0 to the list of possible notforloan statuses
+            # The lib value is replaced in the template
+            push @$arr, { authorised_value => 0, id => 'stat0' , lib => 'ignore' };
             @notforloans = map { $_->{'authorised_value'} } @$arr;
         }
+        $hash->{values} = $arr;
+        push @$statuses, $hash;
     }
 }