Bug 18928: Remove '(not set)'
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 6 May 2019 17:10:58 +0000 (12:10 -0500)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 1 Jul 2019 13:59:38 +0000 (14:59 +0100)
The "(not set)" part must be removed IMO, I am not sure I understand its goal.
Now that we have 1 entry per rule (and not 1 DB row for the whole "Default
checkout, hold and return policy for Centerville" table), it will be harder
to handle it correctly. Not impossible, but if not really needed I would prefer
to just remove it. If a rule is not set, the cell is empty or the dropdown list
displays the option "Not set", which seems to correct the problem.

Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt

index 3356961..f7e4e0a 100644 (file)
                     <th>Actions</th>
                 </tr>
                 <tr>
-                    <td><em>Defaults[% UNLESS ( default_rules ) %] (not set)[% END %]</em></td>
+                    <td><em>Defaults</em></td>
                     <td>
                         [% SET patron_maxissueqty = CirculationRules.Search( current_branch, undef, undef, 'patron_maxissueqty' ) %]
                         <input type="text" name="patron_maxissueqty" size="3" value="[% patron_maxissueqty | html %]"/>