Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8 Pt 1
authorDavid Cook <dcook@prosentient.com.au>
Tue, 23 Dec 2014 02:44:18 +0000 (13:44 +1100)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 30 Mar 2015 16:36:41 +0000 (13:36 -0300)
The UTF-8 charset in the content type is written as "utf8" instead of "utf-8"
in SendAlerts(), which causes UTF-8 characters to display incorrectly.

_TEST PLAN_

Before Applying:

1) Edit ACCTDETAILS
2) Add some UTF-8 characters
I recommend using the following website
http://www.ltg.ed.ac.uk/~richard/unicode-sample.html

In my tests, I added the samples from Hebrew, Arabic, Basic Latin,
Latin-1 Supplement, Latin Extended-A, and Latin Extended-B.

3) Set the system preference "AutoEmailOpacUser" to "Send"
4) Create a new user account with your email address

5) Note that the email in your inbox doesn't display the Unicode
characters correctly

Apply the patch

6) Create a new user account with your email address
7) Note that the email in your inbox _does_ display the
Unicode characters correctly.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

C4/Letters.pm

index a11c862..3de1aa3 100644 (file)
@@ -432,7 +432,7 @@ sub SendAlerts {
                     subject => Encode::encode( "utf8", "" . $letter->{title} ),
                     message =>
                       Encode::encode( "utf8", "" . $letter->{content} ),
-                    contenttype => 'text/plain; charset="utf8"',
+                    contenttype => 'text/plain; charset="utf-8"',
 
                 }
             );
@@ -519,7 +519,7 @@ sub SendAlerts {
             From           => $userenv->{emailaddress},
             Subject        => Encode::encode( "utf8", "" . $letter->{title} ),
             Message        => Encode::encode( "utf8", "" . $letter->{content} ),
-            'Content-Type' => 'text/plain; charset="utf8"',
+            'Content-Type' => 'text/plain; charset="utf-8"',
         );
 
         $mail{'Reply-to'} = C4::Context->preference('ReplytoDefault')
@@ -568,7 +568,7 @@ sub SendAlerts {
                 sender  => $branchdetails->{'branchreturnpath'},
                 subject => Encode::encode( "utf8", "" . $letter->{'title'} ),
                 message => Encode::encode( "utf8", "" . $letter->{'content'} ),
-                contenttype => 'text/plain; charset="utf8"'
+                contenttype => 'text/plain; charset="utf-8"'
             }
         );
         sendmail(%mail) or carp $Mail::Sendmail::error;