Bug 21385: (follow-up) make query consistent
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 24 Sep 2018 12:33:59 +0000 (13:33 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 1 Oct 2018 23:57:17 +0000 (23:57 +0000)
The expected items query wasn't consistent with other queries in this
module with regards to identifying cancelled orders

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

C4/Acquisition.pm

index 6a15e2c..d635a49 100644 (file)
@@ -700,7 +700,7 @@ sub GetBasketsInfosByBookseller {
           COUNT(DISTINCT aqorders.biblionumber) AS total_biblios,
           SUM(
             IF(aqorders.datereceived IS NULL
-              AND aqorders.datecancellationprinted IS NULL
+              AND (aqorders.datecancellationprinted IS NULL OR aqorders.datecancellationprinted='0000-00-00')
             , aqorders.quantity
             , 0)
           ) AS expected_items