Bug 22505: Add column configuration to patron list table
authorJulian Maurice <julian.maurice@biblibre.com>
Wed, 13 Mar 2019 13:19:44 +0000 (14:19 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 28 Mar 2019 18:03:48 +0000 (18:03 +0000)
Test plan:
1. Create a list of patrons
2. Add some patrons to this list
3. Go to this patron list
   (/cgi-bin/koha/patron_lists/list.pl?patron_list_id=XXX)
4. Verify that you can show/hide all columns except the one containing
   the checkbox
5. Verify that you can export the table data using the Export menu
6. Go to admin/columns_settings.pl, and verify that the configuration
   works for table 'patron-list-table'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

admin/columns_settings.yml
koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt

index 409b83b..f033cd3 100644 (file)
@@ -590,6 +590,28 @@ modules:
           columnname: itemtype
         -
           columnname: status
+    patron-lists:
+      patron-list-table:
+        -
+          columnname: checkbox
+          cannot_be_toggled: 1
+          cannot_be_modified: 1
+        -
+          columnname: card
+        -
+          columnname: firstname
+        -
+          columnname: surname
+        -
+          columnname: address
+        -
+          columnname: category
+        -
+          columnname: library
+        -
+          columnname: expires_on
+        -
+          columnname: circ_notes
 
   reports:
     lostitems:
index 64bbe64..0c184ee 100644 (file)
@@ -1,8 +1,10 @@
 [% USE raw %]
 [% USE Asset %]
 [% USE KohaDates %]
+[% USE ColumnsSettings %]
 [% SET footerjs = 1 %]
 [% INCLUDE 'doc-head-open.inc' %]
+[% INCLUDE 'columns_settings.inc' %]
 <title>Koha &rsaquo; Tools &rsaquo; Patron lists &rsaquo; [% list.name | html %] &rsaquo; Add patrons</title>
 [% INCLUDE 'doc-head-close.inc' %]
 
         $(document).ready(function() {
             $('#patrons_to_add_fieldset').hide();
 
-                $('#patron-list-table').dataTable($.extend(true, {}, dataTablesDefaults, {
+                var columns_settings_table = [% ColumnsSettings.GetColumns('members', 'patron-lists', 'patron-list-table', 'json') | $raw %]
+                KohaTable('patron-list-table', {
                     "order": [[ 3, "asc" ]],
                     "aoColumns": [
                         null,null,null,null,null,null,null,{ "sType": "title-string" },null
                         { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false },
                     ],
                     "sPaginationType": "four_button"
-                } ));
+                }, columns_settings_table);
 
             patron_autocomplete({
                 patron_container: $("#patrons_to_add"),