bug 10728: fix additional log noise generated by subscription-renew.pl
authorGalen Charlton <gmc@esilibrary.com>
Wed, 14 Aug 2013 14:53:25 +0000 (14:53 +0000)
committerChris Hall <followingthepath@gmail.com>
Fri, 22 Nov 2013 21:53:39 +0000 (10:53 +1300)
To test:

[1] Use the renew link to bring up the subscription renewal form.
[2] Verify that a warning message containing the text
    'Problem = a value of 1 has been passed to param without key'
    was not added to the Apache error log.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 6e864430caaa951b06d5fecff3fe7864317e5e26)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 3cd7313007061c0e644d0daf37cf79739c342717)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
(cherry picked from commit 3cd7313007061c0e644d0daf37cf79739c342717)
Signed-off-by: Chris Hall <followingthepath@gmail.com>
(cherry pick from commit 752f8049edff0d0a1c9061dc5141fd3af7436869)

serials/subscription-renew.pl

index 47b35f0..280b776 100755 (executable)
@@ -60,7 +60,7 @@ my $query = new CGI;
 my $dbh   = C4::Context->dbh;
 
 my $mode           = $query->param('mode') || q{};
-my $op             = $query->param('op') || q{};
+my $op             = $query->param('op') || 'display';
 my $subscriptionid = $query->param('subscriptionid');
 my $done = 0;    # for after form has been submitted
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(