Bug 14570: (follow-up) fix qa FAIL tests

Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/Koha/Patron/Relationships.pm b/Koha/Patron/Relationships.pm
index 0cdfa9f..db3b107 100644 (file)
--- a/Koha/Patron/Relationships.pm
+++ b/Koha/Patron/Relationships.pm
@@ -82,8 +82,6 @@ sub guarantees {
     return wantarray ? $guarantees->as_list : $guarantees;
 }
 
-=cut
-
 =head3 type
 
 =cut
@@ -92,6 +90,10 @@ sub _type {
     return 'BorrowerRelationship';
 }
 
+=head3 object_class
+
+=cut
+
 sub object_class {
     return 'Koha::Patron::Relationship';
 }

diff --git a/Koha/Patrons.pm b/Koha/Patrons.pm
index 8053719..4a5f63c 100644 (file)
--- a/Koha/Patrons.pm
+++ b/Koha/Patrons.pm
@@ -368,6 +368,10 @@ sub _type {
     return 'Borrower';
 }
 
+=head3 object_class
+
+=cut
+
 sub object_class {
     return 'Koha::Patron';
 }

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
index 3c41a25..5fb4889 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ -824,7 +824,7 @@
                             </li>
 
                             [% IF relatives_issues_count %]
-                                <li><a id="relatives-issues-tab" href="#relatives-issues">[% relatives_issues_count %] Relatives' checkouts</a></li>
+                                <li><a id="relatives-issues-tab" href="#relatives-issues">[% relatives_issues_count | html %] Relatives' checkouts</a></li>
                             [% END %]
 
                             <li>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
index ec20030..bdb7bf8 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ -470,23 +470,23 @@
             </li>
         [% END %]
 
-               [% UNLESS norelationship %]
-                       [% IF possible_relationships %]
+        [% UNLESS norelationship %]
+            [% IF possible_relationships %]
                 <li>
                     <label for="relationship">Relationship: </label>
                     <select class="relationship" name="relationship">
                         <option value=""></option>
                         [% FOREACH pr IN possible_relationships.split('\|') %]
                             [% IF pr == relationship %]
-                                <option value="[% pr %]" selected="selected">[% pr %]</option>
+                                <option value="[% pr | html %]" selected="selected">[% pr | html %]</option>
                             [% ELSE %]
-                                <option value="[% pr %]">[% pr %]</option>
+                                <option value="[% pr | html %]">[% pr | html %]</option>
                             [% END %]
                         [% END %]
                     </select>
                 </li>
-                       [% END %]
-               [% END %]
+            [% END %]
+        [% END %]
 
         [% UNLESS nophone %]
             <li>
@@ -1231,7 +1231,7 @@
             [% END %]
 
             [% IF guarantor %]
-                select_user( '[% guarantor.borrowernumber %]', [% To.json( guarantor.unblessed ) | $raw %] );
+                select_user( '[% guarantor.borrowernumber | html %]', [% To.json( guarantor.unblessed ) | $raw %] );
             [% END %]
 
             $("#cn_max").hide();

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
index 5170914..1c3b2c3 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
@@ -60,7 +60,7 @@
                     </li>
                 [% END %]
             [% END %]
-           </ol>
+        </ol>
     </div>
 </div>
 </div>

diff --git a/members/memberentry.pl b/members/memberentry.pl
index 9aa1462..fbf2866 100755 (executable)
--- a/members/memberentry.pl
+++ b/members/memberentry.pl
@@ -108,7 +108,8 @@ my $userenv = C4::Context->userenv;
 $template->param( relationships => scalar $patron->guarantor_relationships ) if $patron;
 
 my $guarantor_id = $input->param('guarantor_id');
-my $guarantor = Koha::Patrons->find( $guarantor_id ) if $guarantor_id;
+my $guarantor = undef;
+$guarantor = Koha::Patrons->find( $guarantor_id ) if $guarantor_id;
 $template->param( guarantor => $guarantor );
 
 my @delete_guarantor = $input->multi_param('delete_guarantor');

diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t
index 0130824..8570eb0 100755 (executable)
--- a/t/db_dependent/Items.t
+++ b/t/db_dependent/Items.t
@@ -589,7 +589,7 @@ subtest 'Koha::Item(s) tests' => sub {
     is( ref($holdingbranch), 'Koha::Library', "Got Koha::Library from holding_branch method" );
     is( $holdingbranch->branchcode(), $library2->{branchcode}, "Home branch code matches holdingbranch" );
 
-    my $biblio = $item->biblio();
+    $biblio = $item->biblio();
     is( ref($biblio), 'Koha::Biblio', "Got Koha::Biblio from biblio method" );
     is( $biblio->title(), 'Silence in the library', 'Title matches biblio title' );