Bug 21036: Fix uninitialized value within @itemnumber in string ne

Line from 16.11 log:
Use of uninitialized value within @itemnumber in string ne at /usr/share/koha/prodclone/reserve/modrequest.pl line 70.

Test plan:
Read the change. Not 100% identical (numeric zero) but should be enough.
This line is probably not needed at all.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 4560d9623663e9fd0b60f9a39ec53082cdd90f24)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit ffae11293afb3f80e434e7c84b75e240f7512350)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

diff --git a/reserve/modrequest.pl b/reserve/modrequest.pl
index 6b4061c..0d1b2d0 100755 (executable)
--- a/reserve/modrequest.pl
+++ b/reserve/modrequest.pl
@@ -66,7 +66,7 @@ if ($CancelBorrowerNumber) {
 # 2) Cancel or modify the queue list of reserves (without item linked)
 else {
     for (my $i=0;$i<$count;$i++){
-        undef $itemnumber[$i] unless $itemnumber[$i] ne '';
+        undef $itemnumber[$i] if !$itemnumber[$i];
         ModReserve({
             rank => $rank[$i],
             reserve_id => $reserve_id[$i],