Bug 14760: Disabled courses display in the course reserves list for items
authorKyle M Hall <kyle@bywatersolutions.com>
Mon, 31 Aug 2015 13:36:02 +0000 (09:36 -0400)
committerMason James <mtj@kohaaloha.com>
Mon, 28 Sep 2015 12:14:18 +0000 (01:14 +1300)
If an item is on reserve for two courses but one of those courses is
disabled, both courses are still listed on opac-detail.pl!

Test Plan:
1) Enable course reserves
2) Create two courses
3) Place one item on reserve for both courses
4) Disable one of the two courses
5) View the record details for that record/item
6) You should see both courses listed in the course reserves column
7) Apply this patch
8) Reload the page
9) You should now only see the active course in the course reseves column

Followed test plan. Works as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 73e9dcb70fcf24dc87af7c5af6f38102206863ae)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
(cherry picked from commit 9c31f1af9bb7b87dd794f40dd2bc7673b720c674)
Signed-off-by: Liz Rea <wizzyrea@gmail.com>

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt

index 536dc97..0a169ee 100644 (file)
                         <td>
                             [% IF ITEM_RESULT.course_reserves %]
                                 [% FOREACH r IN ITEM_RESULT.course_reserves %]
-                                    <p>
-                                        <a href="opac-course-details.pl?course_id=[% r.course.course_id %]">
-                                        [% r.course.course_name %]
-                                        <!--[% IF r.course.course_number %] [% r.course.course_number %] [% END %]-->
-                                        [% IF r.course.section %] [% r.course.section %] [% END %]
-                                        [% IF r.course.term %] [% AuthorisedValues.GetByCode( 'TERM', r.course.term ) %] [% END %]
-                                        </a>
-                                    </p>
+                                    [% IF r.course.enabled == 'yes' %]
+                                        <p>
+                                            <a href="opac-course-details.pl?course_id=[% r.course.course_id %]">
+                                            [% r.course.course_name %]
+                                            <!--[% IF r.course.course_number %] [% r.course.course_number %] [% END %]-->
+                                            [% IF r.course.section %] [% r.course.section %] [% END %]
+                                            [% IF r.course.term %] [% AuthorisedValues.GetByCode( 'TERM', r.course.term ) %] [% END %]
+                                            </a>
+                                        </p>
+                                    [% END %]
                                 [% END %]
                             [% END %]
                         </td>