Bug 19135: Restore AllowHoldsOnPatronsPossessions behaviour

Bug caused by
  commit bc39f0392bbebaad4c083f81308f652a325be042
  Bug 14695 - Add ability to place multiple item holds on a given record per patron

Test Plan:
1) Set AllowHoldsOnPatronsPossessions to "Don't"
2) Check out an item to a patron
3) Place a hold on that item for the same patron
4) Note you are allowed to with no alert
5) Delete the hold
6) Apply this patch
7) Place a hold on that item for the same patron
8) Note you recieve an alert now

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 46ff8df19544e3e7c16a4e3f21b3b14bc043dd88)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 4d22af870d1051d963cab31169a7f536864e56b0)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

diff --git a/reserve/request.pl b/reserve/request.pl
index bc55fdf..c156ab6 100755 (executable)
--- a/reserve/request.pl
+++ b/reserve/request.pl
@@ -260,11 +260,10 @@ foreach my $biblionumber (@biblionumbers) {
 
     # Check to see if patron is allowed to place holds on records where the
     # patron already has an item from that record checked out
-    my $alreadypossession;
     if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions')
         && CheckIfIssuedToPatron( $borrowerinfo->{borrowernumber}, $biblionumber ) )
     {
-        $template->param( alreadypossession => $alreadypossession, );
+        $template->param( alreadypossession => 1, );
     }