Bug 16280: purge_suggestions.pl: Cron job log should tell number of days used
authorMarc Véron <veron@veron.ch>
Sun, 17 Apr 2016 16:52:06 +0000 (18:52 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 5 Nov 2018 14:41:05 +0000 (14:41 +0000)
To test:
- Apply patch
- Set syspref CronjobLog to "Log"
- Set syspref PurgeSuggestionsOlderThan e.g. to 20
- From console, run misc/cronjobs/purge_suggestions.pl
- Check entry in cgi-bin/koha/admin/preferences.pl?op=search&searchfield=log
- Verify that log entry contains number of days (20, same as in syspref)
- From console, run misc/cronjobs/purge_suggestions.pl -days 100
- Verify that log entry contains number of days (100, same as in param -days)

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

misc/cronjobs/purge_suggestions.pl

index 766f501..58a9a1d 100755 (executable)
@@ -63,7 +63,7 @@ if( !$confirm || $help || !defined($days) ) {
     print "No confirm parameter passed!\n\n" if !$confirm && !$help;
     print $usage;
 } elsif( $days and $days > 0 ) {
-    cronlogaction();
+    cronlogaction( " ( days: $days )");
     DelSuggestionsOlderThan($days);
 } else {
     warn "This script requires a positive number of days. Aborted.\n";