Bug 21987: Do not generate true color thumbnails if not needed
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 18 Dec 2018 17:02:19 +0000 (14:02 -0300)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 19 Mar 2019 23:25:47 +0000 (23:25 +0000)
If the original image is not a true color image we should not generate a
true color thumbnail.

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 5c41d584cb654efbfd8c854bac0d30d87a054ab5)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 8928ba93250633eb82199e06c2198487b955d734)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

C4/Images.pm

index 37b2417..856e894 100644 (file)
@@ -179,8 +179,8 @@ sub _scale_image {
           and warn "Reducing image by "
           . ( $percent_reduce * 100 )
           . "\% or to $width_reduce pix X $height_reduce pix";
-        my $newimage = GD::Image->new( $width_reduce, $height_reduce, 1 )
-          ;        #'1' creates true color image...
+        my $newimage = GD::Image->new( $width_reduce, $height_reduce, $image->trueColor )
+          ;        # if third is set, creates true color image
         $newimage->copyResampled( $image, 0, 0, 0, 0, $width_reduce,
             $height_reduce, $width, $height );
         return $newimage;