Bug 7677: QA followup

Fix 'unique contraint primary' error when receiving serials

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/Koha/Serial/Item.pm b/Koha/Serial/Item.pm
index 3509b3d..c3286a5 100644 (file)
--- a/Koha/Serial/Item.pm
+++ b/Koha/Serial/Item.pm
@@ -39,7 +39,7 @@ Koha::Serial::Item - Koha Serial Item Object class
 
 =cut
 
-sub type {
+sub _type {
     return 'Serialitem';
 }
 

diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl
index 12efa67..2bff94b 100755 (executable)
--- a/serials/serials-edit.pl
+++ b/serials/serials-edit.pl
@@ -257,7 +257,7 @@ if ( $op and $op eq 'serialchangestatus' ) {
             my $previous = GetPreviousSerialid($subscriptionids[$i]);
             if ($previous) {
 
-                my $serialitem = Koha::Serial::Items->find( $previous );
+                my $serialitem = Koha::Serial::Items->search( {serialid => $previous} )->next;
                 my $itemnumber = $serialitem ? $serialitem->itemnumber : undef;
                 if ($itemnumber) {