Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete

Just a find and replace on the changed system preference name.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/C4/Auth.pm b/C4/Auth.pm
index 7a7d9f5..725ab74 100644 (file)
--- a/C4/Auth.pm
+++ b/C4/Auth.pm
@@ -480,7 +480,7 @@ sub get_template_and_user {
             AmazonCoverImages                                                          => C4::Context->preference("AmazonCoverImages"),
             AutoLocation                                                               => C4::Context->preference("AutoLocation"),
             "BiblioDefaultView" . C4::Context->preference("IntranetBiblioDefaultView") => 1,
-            PatronAutocompletion                                                       => C4::Context->preference("PatronAutocompletion"),
+            PatronAutoComplete                                                       => C4::Context->preference("PatronAutoComplete"),
             FRBRizeEditions                                                            => C4::Context->preference("FRBRizeEditions"),
             IndependentBranches                                                        => C4::Context->preference("IndependentBranches"),
             IntranetNav                                                                => C4::Context->preference("IntranetNav"),

diff --git a/C4/UsageStats.pm b/C4/UsageStats.pm
index 268f72f..20ab194 100644 (file)
--- a/C4/UsageStats.pm
+++ b/C4/UsageStats.pm
@@ -182,7 +182,7 @@ sub BuildReport {
         TransferWhenCancelAllWaitingHolds
         AllowAllMessageDeletion
         AllowOfflineCirculation
-        PatronAutocompletion
+        PatronAutoComplete
         CircAutoPrintQuickSlip
         DisplayClearScreenButton
         FilterBeforeOverdueReport

diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl
index d14fc3d..f65402d 100755 (executable)
--- a/circ/branchtransfers.pl
+++ b/circ/branchtransfers.pl
@@ -241,7 +241,7 @@ $template->param(
     setwaiting              => $setwaiting,
     trsfitemloop            => \@trsfitemloop,
     errmsgloop              => \@errmsgloop,
-    PatronAutocompletion    => C4::Context->preference("PatronAutocompletion"),
+    PatronAutoComplete    => C4::Context->preference("PatronAutoComplete"),
 );
 
 # Checking if there is a Fast Cataloging Framework

diff --git a/circ/circulation.pl b/circ/circulation.pl
index 294c8a7..60e5455 100755 (executable)
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -636,7 +636,7 @@ my $has_modifications = Koha::Patron::Modifications->search( { borrowernumber =>
 $template->param(
     debt_confirmed            => $debt_confirmed,
     SpecifyDueDate            => $duedatespec_allow,
-    PatronAutocompletion      => C4::Context->preference("PatronAutocompletion"),
+    PatronAutoComplete      => C4::Context->preference("PatronAutoComplete"),
     debarments                => scalar GetDebarments({ borrowernumber => $borrowernumber }),
     todaysdate                => output_pref( { dt => dt_from_string()->set(hour => 23)->set(minute => 59), dateformat => 'sql' } ),
     has_modifications         => $has_modifications,

diff --git a/installer/data/mysql/atomicupdate/bug_23697.perl b/installer/data/mysql/atomicupdate/bug_23697.perl
index 84655c3..f53decb 100644 (file)
--- a/installer/data/mysql/atomicupdate/bug_23697.perl
+++ b/installer/data/mysql/atomicupdate/bug_23697.perl
@@ -1,6 +1,6 @@
 $DBversion = 'XXX'; # will be replaced by the RM
 if( CheckVersion( $DBversion ) ) {
-    $dbh->do( "UPDATE systempreferences SET variable="PatronAutocompletion" WHERE variable="CircAutocompl" LIMIT 1" );
+    $dbh->do( "UPDATE systempreferences SET variable="PatronAutoComplete" WHERE variable="CircAutocompl" LIMIT 1" );
     SetVersion( $DBversion );
-    print "Upgrade to $DBversion done (Bug 23697 - Rename CircAutocompl system preference to PatronAutocompletion)\n";
+    print "Upgrade to $DBversion done (Bug 23697 - Rename CircAutocompl system preference to PatronAutoComplete)\n";
 }

diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
index f25b0d4..f1ace4b 100644 (file)
--- a/installer/data/mysql/sysprefs.sql
+++ b/installer/data/mysql/sysprefs.sql
@@ -463,7 +463,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('OverduesBlockCirc','noblock','noblock|confirmation|block','When checking out an item should overdues block checkout, generate a confirmation dialogue, or allow checkout','Choice'),
 ('OverduesBlockRenewing','allow','allow|blockitem|block','If any of patron checked out documents is late, should renewal be allowed, blocked only on overdue items or blocked on whatever checked out document','Choice'),
 ('PatronAnonymizeDelay','',NULL,'Delay for anonymizing patrons', 'Integer'),
-('PatronAutocompletion','1','Try|Don\'t try','to guess the patron being entered while typing a patron search for circulation or patron search. Only returns the first 10 results at a time.','YesNo'),
+('PatronAutoComplete','1','Try|Don\'t try','to guess the patron being entered while typing a patron search for circulation or patron search. Only returns the first 10 results at a time.','YesNo'),
 ('patronimages','0',NULL,'Enable patron images for the Staff Client','YesNo'),
 ('PatronRemovalDelay','',NULL,'Delay for removing anonymized patrons', 'Integer'),
 ('PatronSelfModificationBorrowerUnwantedField','',NULL,'Name the fields you don\'t want to display when a patron is editing their information via the OPAC.','free'),

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
index a6bf7b7..f2ee274 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
@@ -81,7 +81,7 @@
 [% END %]
 
 [% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
-    [% IF ( PatronAutocompletion ) %]
+    [% IF ( PatronAutoComplete ) %]
         <script>
             $(document).ready(function(){
                 var obj = $( "#findborrower" ).autocomplete({
@@ -109,7 +109,7 @@
         </script>
     [% END %]
 [% END %]
-[% IF ( PatronAutocompletion ) %]
+[% IF ( PatronAutoComplete ) %]
     <script>
     $(document).ready(function(){
         var obj = $( "#searchmember" ).autocomplete({

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc
index f1b0de0..c66eefb 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc
@@ -2,7 +2,7 @@
     <div id="circ_search" class="residentsearch">
     <p class="tip">Enter patron card number or partial name:</p>
     <form action="/cgi-bin/koha/circ/circulation.pl" id="patronsearch" method="post">
-    [% IF ( PatronAutocompletion ) %]
+    [% IF ( PatronAutoComplete ) %]
     <div class="autocomplete">
                 <input autocomplete="off" id="findborrower" name="findborrower" size="40" class="head-searchbox focus" type="text" />
                 <input id="autocsubmit" type="submit" class="submit" value="Submit" />

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
index fff02a6..4ff6a83 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ -15,7 +15,7 @@ Circulation:
             - the automatic redirection to another patron when a patron barcode is scanned instead of a book.
             - This should not be enabled if you have overlapping patron and book barcodes.
         -
-            - pref: PatronAutocompletion
+            - pref: PatronAutoComplete
               choices:
                   yes: Try
                   no: "Don't try"

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
index 546b757..43c0f2a 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ -1224,7 +1224,7 @@
             });
 
             [% UNLESS ( patron || patron.borrowernumber || borrowers || noitems ) %]
-                [% IF ( PatronAutocompletion ) %]
+                [% IF ( PatronAutoComplete ) %]
                 $( "#patron" ).autocomplete({
                     source: "/cgi-bin/koha/circ/ysearch.pl",
                     minLength: 3,

diff --git a/members/members-home.pl b/members/members-home.pl
index 755f961..73a370d 100755 (executable)
--- a/members/members-home.pl
+++ b/members/members-home.pl
@@ -70,7 +70,7 @@ $template->param(
 
 $template->param(
     alphabet => C4::Context->preference('alphabet') || join (' ', 'A' .. 'Z'),
-    PatronAutocompletion => C4::Context->preference('PatronAutocompletion'),
+    PatronAutoComplete => C4::Context->preference('PatronAutoComplete'),
     patron_lists => [ GetPatronLists() ],
     PatronsPerPage => C4::Context->preference("PatronsPerPage") || 20,
 );

diff --git a/t/db_dependent/UsageStats.t b/t/db_dependent/UsageStats.t
index b27aaed..c25b44e 100644 (file)
--- a/t/db_dependent/UsageStats.t
+++ b/t/db_dependent/UsageStats.t
@@ -435,7 +435,7 @@ sub mocking_systempreferences_to_a_set_value {
         TransferWhenCancelAllWaitingHolds
         AllowAllMessageDeletion
         AllowOfflineCirculation
-        PatronAutocompletion
+        PatronAutoComplete
         CircAutoPrintQuickSlip
         DisplayClearScreenButton
         FilterBeforeOverdueReport