Bug 25236: Fix semantic heading for opac-topissues.inc
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 11 Jun 2020 10:44:53 +0000 (11:44 +0100)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Fri, 24 Jul 2020 09:53:22 +0000 (11:53 +0200)
Prior to this patch, the opac-topissues side navigation box contained
semantically incorrect headings.

Test plan
0/ Enable 'OpacTopIssues'
1/ Navigate to the top issues page via the 'Most popular' link
2/ Inspect the 'Refine your search' elements on the left side of the screen.
   Note that the headings are H1 (Koha page title) > H4 (Refine your search)
3/ Apply this patch
4/ Reload the page
5/ Re-inspect the 'Refine your search' elements and note the heading
   semantics are now H1 (Title of page) > H2 (Refine your search)
6/ Note the appearance of the box is still reasonable
7/ Signoff

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 62795521eedc02e11bef520c8b980d480b7e02ae)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 0a01f91887ee5ca24c7950cbd59984dbd335404d)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

(cherry picked from commit 35e1f053f9fa0d62b004526e7d55a3481b8be7ea)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc

index 6f08f1c..fe07f1e 100644 (file)
@@ -4,7 +4,7 @@
 
 <div id="search-facets">
     <form method="get" action="/cgi-bin/koha/opac-topissues.pl">
-    <h4><a href="#" class="menu-collapse-toggle">Refine your search</a></h4>
+    <h2><a href="#" class="menu-collapse-toggle">Refine your search</a></h2>
             <ul class="menu-collapse">
                 <li><label for="limit">Show the top </label>
                             <select name="limit" id="limit">