Bug 21991: Pass param names to report limit tool
authorNick Clemens <nick@bywatersolutions.com>
Wed, 12 Dec 2018 16:16:50 +0000 (16:16 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Sat, 22 Dec 2018 17:37:59 +0000 (17:37 +0000)
To test:
1 - Define a report like:
SELECT barcode, itemnumber
FROM items
WHERE (homebranch = <<Branch|branches>> AND 0 ) OR
<<Branch|branches>>=<<Branch|branches>>
2 - Run it, you get results
3 - Select 'Rows to display' 50
4 - No results
5 - Apply patch
6 - Run report
7 - Change display rows
8 - Results remain!

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 702c727470d332615fb1428c55f503183935f29d)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 4de2ad9839319778333c1a3163f318e437ff01fb)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt

index 9dde026..e0e0715 100644 (file)
@@ -708,6 +708,9 @@ canned reports and writing custom SQL reports.</p>
     [% FOREACH p IN sql_params %]
         <input type="hidden" name="sql_params" value="[% p %]"/>
     [% END %]
+    [% FOREACH n IN param_names %]
+        <input type="hidden" name="param_name" value="[% n | html %]"/>
+    [% END %]
 
     <label for="limit">Rows per page: </label>
     <select name="limit" id="limit">