Bug 8132: No changes but disable checkboxes

When the list of items is displayed we already know if there will be a
problem during the deletion. So let's disable the checkbox to tell the
user in advance that items cannot be deleted.

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
index 3d11faf..8701d9e 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
@@ -1,6 +1,7 @@
 [% USE raw %]
 [% USE Asset %]
 [% SET footerjs = 1 %]
+[% PROCESS 'i18n.inc' %]
 [% INCLUDE 'doc-head-open.inc' %]
 <title>Koha &rsaquo; Tools &rsaquo; Batch item deletion</title>
 [% INCLUDE 'doc-head-close.inc' %]
@@ -108,9 +109,22 @@
               <tr>
                 [% IF show %]
                   [% IF item_loo.nomod %]
-                    <td class="error">Cannot edit</td>
-                  [% ELSE %]
-                    <td><input type="checkbox" name="itemnumber" value="[% item_loo.itemnumber | html %]" id="row[% item_loo.itemnumber | html %]" checked="checked" data-is-onloan="[% item_loo.onloan | html %]" /></td>
+                    <td class="error">Cannot delete</td>
+                [% ELSE %]
+                    [% SET can_be_deleted = item_loo.item.safe_to_delete %]
+                    [% IF can_be_deleted == 1 %]
+                        <td><input type="checkbox" name="itemnumber" value="[% item_loo.itemnumber | html %]" id="row[% item_loo.itemnumber | html %]" checked="checked" /></td>
+                    [% ELSE %]
+                        [% SWITCH can_be_deleted %]
+                        [% CASE "book_on_loan" %][% SET cannot_delete_reason = t("Item is checked out") %]
+                        [% CASE "not_same_branch" %][% SET cannot_delete_reason = t("Item does not belongs to your library") %]
+                        [% CASE "book_reserved" %][% SET cannot_delete_reason = t("Item has a waiting hold") %]
+                        [% CASE "linked_analytics" %][% SET cannot_delete_reason = t("Item has linked analytics") %]
+                        [% CASE %][% SET cannot_delete_reason = t("Unknown reason") %]
+                        [% END %]
+
+                        <td><input type="checkbox" name="itemnumber" value="[% item_loo.itemnumber | html %]" id="row[% item_loo.itemnumber | html %]" disabled="disabled" title="[% cannot_delete_reason %]"/></td>
+                    [% END %]
                   [% END %]
                 [% ELSE %]
                   <td>&nbsp;</td>

diff --git a/tools/batchMod.pl b/tools/batchMod.pl
index 8b13257..a7e3188 100755 (executable)
--- a/tools/batchMod.pl
+++ b/tools/batchMod.pl
@@ -633,6 +633,7 @@ sub BuildItemsData{
             $this_row{biblionumber} = $biblio->biblionumber;
             $this_row{holds}        = $biblio->holds->count;
             $this_row{item_holds}   = Koha::Holds->search( { itemnumber => $itemnumber } )->count;
+            $this_row{item}         = Koha::Items->find($itemnumber);
 
                        if (%this_row) {
                                push(@big_array, \%this_row);
@@ -658,6 +659,7 @@ sub BuildItemsData{
       $row_data{biblionumber} = $row->{biblionumber};
       $row_data{holds}        = $row->{holds};
       $row_data{item_holds}   = $row->{item_holds};
+      $row_data{item}         = $row->{item};
       my $is_on_loan = C4::Circulation::IsItemIssued( $row->{itemnumber} );
       $row_data{onloan} = $is_on_loan ? 1 : 0;
                        push(@item_value_loop,\%row_data);