Bug 22288: Correct item search in batchMod by barcode file

To test:
1 - Have a list of barcodes that exist in your catalog
2 - Go to Tools->Batch item modification
3 - Attempt to modify items using the list
4 - Get an error page
5 - Apply patch
6 - Repeat
7 - Modification should work correctly

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/tools/batchMod.pl b/tools/batchMod.pl
index 85077ab..e5b6032 100755 (executable)
--- a/tools/batchMod.pl
+++ b/tools/batchMod.pl
@@ -254,9 +254,9 @@ if ($op eq "show"){
 
         @contentlist = uniq @contentlist;
         if ($filecontent eq 'barcode_file') {
-            my $existing_items = Koha::Items->search({ itemnumber => \@contentlist });
+            my $existing_items = Koha::Items->search({ barcode => \@contentlist });
             @itemnumbers = $existing_items->get_column('itemnumber');
-            my %exists = map {$_=>1} @{$existing_items->get_column('barcode')};
+            my %exists = map {$_=>1} $existing_items->get_column('barcode');
             @notfoundbarcodes = grep { !$exists{$_} } @contentlist;
         }
         elsif ( $filecontent eq 'itemid_file') {