Bug 11231: remove reference to ambiguous notes column from two hold request reports
authorFrancesca Moore <francescalamoore@gmail.com>
Tue, 14 Jan 2014 23:03:51 +0000 (12:03 +1300)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 13 Aug 2014 18:09:25 +0000 (14:09 -0400)
The 'notes' column has been removed from the pending holds and hold
ratios reports as they were not displaying in the first place.

1.apply patch
2.verify that both reports work

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit cc34a816a10ca76004e079032f1a46aec1ccb1c4)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b462dfc66a23d53088e6ad0b9bfa7354a8347cae)

circ/pendingreserves.pl
circ/reserveratios.pl

index 31ecd85..a885dcb 100755 (executable)
@@ -122,7 +122,6 @@ if ( $run_report ) {
             GROUP_CONCAT(DISTINCT items.copynumber
                     ORDER BY items.itemnumber SEPARATOR '<br/>') l_copynumber,
             items.itemnumber,
-            notes,
             notificationdate,
             reminderdate,
             max(priority) as priority,
@@ -181,7 +180,6 @@ if ( $run_report ) {
                 itemcallnumber  => $data->{l_itemcallnumber},
                 enumchron       => $data->{l_enumchron},
                 copyno          => $data->{l_copynumber},
-                notes           => $data->{notes},
                 notificationdate=> $data->{notificationdate},
                 reminderdate    => $data->{reminderdate},
                 count           => $data->{icount},
index 91d1f6a..4c0db00 100755 (executable)
@@ -99,7 +99,7 @@ my $strsth =
                        ORDER BY items.itemnumber SEPARATOR '<br/>') as l_location,
         GROUP_CONCAT(DISTINCT items.itype 
                        ORDER BY items.itemnumber SEPARATOR '<br/>') as l_itype,
-        notes,
+
         reserves.found,
         biblio.title,
         biblio.author,
@@ -141,7 +141,6 @@ while ( my $data = $sth->fetchrow_hashref ) {
             title            => $data->{title},
             subtitle            => $data->{subtitle},
             author           => $data->{author},
-            notes            => $data->{notes},
             itemnum          => $data->{itemnumber},
             biblionumber     => $data->{biblionumber},
             holdingbranch    => $data->{holdingbranch},