Bug 22068: (QA follow-up) Return meaningful error codes

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit e98dacf9f1f8464f0db394da6bc1152f96713597)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 912a97f8b49b89d03ed524bed2072db0a50c4527)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

diff --git a/opac/opac-article-request-cancel.pl b/opac/opac-article-request-cancel.pl
index 0305808..ef9f753 100755 (executable)
--- a/opac/opac-article-request-cancel.pl
+++ b/opac/opac-article-request-cancel.pl
@@ -41,10 +41,14 @@ my $id = $query->param('id');
 
 if ( $id ) {
     my $ar = Koha::ArticleRequests->find( $id );
-    if ( !$ar || $ar->borrowernumber != $borrowernumber ) {
+    if ( !$ar ) {
         print $query->redirect("/cgi-bin/koha/errors/404.pl");
         exit;
     }
+    elsif ( $ar->borrowernumber != $borrowernumber ) {
+        print $query->redirect("/cgi-bin/koha/errors/403.pl");
+        exit;
+    }
 
     $ar->cancel();
 }