Bug 21872: Remove duplicate modulo condition in authorities iterator

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/Koha/BiblioUtils.pm b/Koha/BiblioUtils.pm
index 88395a9..fd6969d 100644 (file)
--- a/Koha/BiblioUtils.pm
+++ b/Koha/BiblioUtils.pm
@@ -131,7 +131,7 @@ sub get_all_biblios_iterator {
     if ($options{slice}) {
         $slice_count = $options{slice}->{count};
         $slice_modulo = $options{slice}->{index};
-        $search_terms = \[ ' mod(biblionumber, ?) = ?', $slice_count, $slice_modulo];
+        $search_terms = \[ 'mod(biblionumber, ?) = ?', $slice_count, $slice_modulo ];
     }
 
     my $database = Koha::Database->new();

diff --git a/Koha/MetadataRecord/Authority.pm b/Koha/MetadataRecord/Authority.pm
index 3a188e7..17245f0 100644 (file)
--- a/Koha/MetadataRecord/Authority.pm
+++ b/Koha/MetadataRecord/Authority.pm
@@ -183,11 +183,10 @@ sub get_all_authorities_iterator {
     if ($options{slice}) {
         $slice_count = $options{slice}->{count};
         $slice_modulo = $options{slice}->{index};
-        $search_terms->{authid} = \[ ' mod ? = ?', $slice_count, $slice_modulo];
         $search_terms = {
             '-and' => [
-                $search_terms,
-                \[ ' mod(authid, ?) = ?', $slice_count, $slice_modulo]
+                %{$search_terms},
+                \[ 'mod(authid, ?) = ?', $slice_count, $slice_modulo ]
             ]
         };
     }