Bug 25974: Remove inline style from table settings administration page
authorOwen Leonard <oleonard@myacpl.org>
Fri, 10 Jul 2020 14:30:09 +0000 (14:30 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 20 Jul 2020 12:05:21 +0000 (14:05 +0200)
This patch removes an inline style attribute from the table settings
administration template. A different style is added to the page's
<style> block to try to accomplish a similar effect of expressing the
hierarchy of the page.

To test, apply the patch and go to Administration -> Table settings.

The individual tables of settings should be offset from the headings
above them.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt

index 384e5e5..3d7a59e 100644 (file)
@@ -24,7 +24,7 @@
                     [% IF tables.$pagename.keys and tables.$pagename.keys.size > 0 %]
                         [% FOR tablename IN tables.$pagename.keys.sort %]
                             [% SET table_id = pagename _ '#' _ tablename %]
-                            <div class="datatable_config" id="[% table_id | html %]" style="border:1px solid #7EA6B2; padding: 1em;">
+                            <div class="datatable_config" id="[% table_id | html %]">
                                 <input type="hidden" name="table_id" value="[% table_id| html %]" />
                                 [% IF pagename == 'additem' AND tablename == 'itemst' %]
                                     <div class="alert">Changes made below will only apply to item subfields that are mapped to the 'items' table. <a href="/cgi-bin/koha/admin/koha2marclinks.pl?tablename=items">Go to Koha to MARC mapping</a></div>
     caption {
         font-size: 115%;
     }
+
+    .datatable_config {
+        margin-left: 1em;
+    }
     .page_name {
         border-top: 1px solid #b9d8d9;
         margin-top: 1em;