Bug 11751: remove dead code related to handling members of institution patrons
authorJonathan Druart <jonathan.druart@biblibre.com>
Wed, 12 Feb 2014 15:34:01 +0000 (16:34 +0100)
committerGalen Charlton <gmc@esilibrary.com>
Tue, 11 Mar 2014 15:05:14 +0000 (15:05 +0000)
commitf10ee65d88c64c23cbcf7fdf9417229b8d159d24
treec4a93fad1b1a0d4c2a1a574d2c83471ed73d9d38
parent26cdaaae777dd21314df90177fe070730575fb85
Bug 11751: remove dead code related to handling members of institution patrons

This patch removes some dead code concerning the handling of patrons
that are members of other, institutional patrons.  This code did not
work; removing it clears the field if somebody wants to do a better
implementation of such relationships between patrons.

This patch:

[1] Removes the memberofinstitution system preference.
[2] Removes the following routines:

    C4::Members::get_institutions()
    C4::Members::add_member_orgs() (and removing this routine
    removes a reference to a borrowers_to_borrowers table that
    does not exist).

There should be no changes whatsoever to system functionality with this
patch (with the trivial exception of the absence of the
memberofinstitution system preference).

Test plan:

[1] Look at the code and use grep, git grep, etc. verify this patch
    does not remove something in use.
[2] Verify that there are no regressions upon adding or editing
    a patron record.
[3] Verify that the memberofinstitution system preference has been
    removed

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Members.pm
circ/circulation.pl
installer/data/mysql/sysprefs.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
members/memberentry.pl