Bug 17925: Disable debugging in reports/bor_issues_top.pl
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 17 Jan 2017 15:49:40 +0000 (16:49 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 12 May 2017 13:09:15 +0000 (09:09 -0400)
commite739fecbc83ff0ee32f155ae7e74c4780a5201c2
treecefb889e33140306a96c16012d9ee482768b78ce
parent6da7ed1d8c17960e1e90b8f197fe948d4ed25bad
Bug 17925: Disable debugging in reports/bor_issues_top.pl

Remove setting $debug to 1. This prevents creation of file
tmp/bor_issues_top.debug.log.
Enable warnings pragma.
Resolve a uninitialized warning on $sep like:
Use of uninitialized value $CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66.

Test plan:
Restart Plack (as you always do when testing).
Remove file /tmp/bor_issues_top.debug.log.
Open Reports/Patrons with the most checkouts.
Check if the file in /tmp has not been created again.
Check the log for warnings after you restarted Plack.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mason James <mtj@kohaaloha.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
reports/bor_issues_top.pl