Bug 16587 - opac-sendbasket.pl is open to XSS
authorChris Cormack <chris@bigballofwax.co.nz>
Wed, 25 May 2016 14:01:41 +0000 (14:01 +0000)
committerChris Cormack <chrisc@catalyst.net.nz>
Wed, 3 Aug 2016 20:29:28 +0000 (08:29 +1200)
commitdbffc29ba7b55594189a923b48b6ae4086cfbe52
tree8df7478b6bd0de697f5a48042bd09a8b4b2989c1
parentdd93d0c662f6a6c0cf2abe236559b30e99f039c4
Bug 16587 - opac-sendbasket.pl is open to XSS

To test
1/ Hit a url like
http://localhost:8080/cgi-bin/koha/opac-sendbasket.pl?email_add=%3Cscript%3Ealert(%27XSS%27)%3C%2Fscript%3Ezz%40zz&comment=tes&bib_list=3

Where bib_list is a valid basket number
2/ Notice you get a javascript alert showing
3/ Apply patch
4/ Notice the text is now escaped

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt