Bug 13254 - Delete record don't wait for confirmation
authorRafal Kopaczka <rkk0@poczta.onet.pl>
Fri, 14 Nov 2014 13:06:22 +0000 (14:06 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 2 Apr 2015 07:34:33 +0000 (09:34 +0200)
commitd953fe6dd1ee0ee5f3c1faf1174c0119580112ec
treecbc7de22c11ab12457c8b9400f09aa40d9e4ef3a
parentc426d4617dcedd3cd127222e4e4015a483df7ae6
Bug 13254 - Delete record don't wait for confirmation

In some cases (eg. when Staf Client Search is active), when user choose
Edit->Delete record on record tool bar, browser don't wait for
confirmation and goes immediately to delete record.

To reproduce:
1. Search for some biblio records and choose one without items attached.
2. Note that there, must be "Return to search results" box on left side,
bug works in that case, when in normal view everything work fine.
3. Click Edit->Delete record, watch that confirmation box shows, but
don't wait for OK and runs immediately. If you are fast enough to
click OK, then you get error as below, because record was deleted
earlier.

To test:
1. Apply patch.
2. Follow reproduce steps.
3. Check if waits for confirmation in all cases.
4. Check if deletes record after confirm.

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Confirmed the problem and that the patch fixes it.
Good catch!
Signed-off-by: Mason James <mtj@kohaaloha.com>
(cherry picked from commit 94636a8a196357171bf6b01cb45c5d97530bb40b)

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc