Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm
authorSlava Shishkin <slavashishkin@gmail.com>
Wed, 13 May 2020 17:20:27 +0000 (20:20 +0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 29 Jun 2020 10:37:01 +0000 (12:37 +0200)
commitd81438e143273a538c09cd16e7f92a83beed4027
tree4afc4285fb2a20d06ea5a6a9fbf999498122f054
parent6886cf93eca9b05dc2ccfa1d681d86e9d95385b4
Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm

This warning was thrown:
    Use of uninitialized value $info{"invalid_username_or_password"}
    in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm
    line 387.

There is the case when hash key can be undefined in numeric comparison.

Fixed by adding additional precheck for
$info{"invalid_username_or_password"} being Perl's "true".

To test:
    1) Go to the first page of the web-installer where it asks to login.
    2) Observe the warning in the log file.
    3) Apply patch.
    4) Repeat step 1.
    7) Check that previous warning suppressed.

Mentored-by: Andrew Nugged <nugged@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/InstallAuth.pm