Bug 23049: Update existing code to use debit_type
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 10 Oct 2019 16:15:10 +0000 (17:15 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 24 Oct 2019 16:24:15 +0000 (17:24 +0100)
commitd661141890dbd56ca2511f435c263395c65bf55e
tree5e6435c432e97321645a8951056654975fffa369
parent8356c56cc27d628ac23758facdb559f38e77cfb9
Bug 23049: Update existing code to use debit_type

* Update C4::Accounts::chargelostitem
* Update C4::Accounts::manualinvoice
* Update C4::Circulation::_FixOverduesOnReturn
* Update C4::Circulation::_FixAccountForLostAndReturned
* Update C4::Overdues::UpdateFine
* Update C4::Overdues::GetFine
* Update C4::Overdues::GetOverduesForBranch
* Update Koha::Account->pay
* Update Koha::Account->add_debit
* Update Koha::Account->non_issues_charges
* Update Koha::Account::Line->apply
* Update Koha::Account::Line->adjust
* Update controller scripts
* Update reports scripts
* Update tests

Test Plan
1) Run the test suit and ensure everything still passes
2) Test reports/cash_register_stats still works
3) Test that adding manual invoices still works
4) Test that making payments still works
5) Test that lost item fee handling still works
6) Test that invoice printing still works
7) Test that the sco still works

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
31 files changed:
C4/Accounts.pm
C4/Circulation.pm
C4/Overdues.pm
Koha/Account.pm
Koha/Account/Line.pm
Koha/Schema/Result/Accountline.pm
catalogue/moredetail.pl
installer/data/mysql/atomicupdate/bug_23049_debit.perl
installer/data/mysql/kohastructure.sql
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc
members/pay.pl
members/paycollect.pl
members/printinvoice.pl
misc/cronjobs/staticfines.pl
opac/opac-user.pl
opac/sco/sco-main.pl
reports/cash_register_stats.pl
t/db_dependent/Accounts.t
t/db_dependent/Circulation.t
t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
t/db_dependent/Circulation/Returns.t
t/db_dependent/Koha/Account.t
t/db_dependent/Koha/Account/DebitTypes.t
t/db_dependent/Koha/Account/Lines.t
t/db_dependent/Koha/Patron.t
t/db_dependent/Reserves.t
t/db_dependent/api/v1/patrons_accounts.t