Bug 12721 - Prevent software error if incorrect fieldnames given in sypref Statistics...
authorMarc Véron <veron@veron.ch>
Sun, 18 Oct 2015 14:28:52 +0000 (16:28 +0200)
committerChris Cormack <chrisc@catalyst.net.nz>
Sun, 19 Jun 2016 21:22:56 +0000 (09:22 +1200)
commitcd9170d249d3ff16c3e0290021a8a40ea4af1a24
tree27dbf1cb325a258a9201057934a3a394235dd6a0
parentf49adba138c7deb6736c50a75e1863b1d4647669
Bug 12721 - Prevent software error if incorrect fieldnames given in sypref StatisticsFields

To reproduce issue:
See comment #1

To test:
- Apply patch
- Leave syspref StatisticsFields empty
- Display statistics for an author

  => Result: Table displays Shelving location, Collection code, Item type
           (as before)

- Change syspref to any combination of location|itype|ccode
  => Result: Table displays columns as appropriate

- Change syspref to some garbage
  => Result: Same as with empty syspref (was crashing without patch)

- Change syspref to valid combination with trailing |
  => Result: Table displays columns as appropriate (was crashing
     without patch)

- Change syspref to a combination of valid and invalid fields
  (location|blah|ccode)
  => Result: Table displays column of valid fields only (was crashing
     without patch)

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 5fc93bce9b786797724539bea1a1689e959078e6)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 36392d8a0cc07c3d5de51ec53c529d3a7d777508)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/Members/Statistics.pm