Bug 19945: ILSDI - Return the reason a reserve is impossible
authorAlex Arnaud <alex.arnaud@biblibre.com>
Wed, 10 Jan 2018 15:31:54 +0000 (15:31 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 28 Jan 2019 13:06:27 +0000 (13:06 +0000)
commitac840a846011f8f6f24686ef68f73e7b59f9704e
tree421e5ab6fab27fa354eeedc2f74b61e35c62f70b
parent094a1cb0703b22d18c061cdc4879c1fc3c76ea80
Bug 19945: ILSDI - Return the reason a reserve is impossible

Currently, the ILDSI services HoldTitle and HoldItem always return a
"NotHoldable" code is the reserve is impossible. We need to know why

Test plan:

 - Apply this patch
 - Place a hold on a non reservable title using ILS-DI web service
   (http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=)
 - you should get the reason instead of NotHoldable,
 - Place a hold on a non reservable item using ILS-DI web service
   (http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1)
 - you should get the reason instead of NotHoldable,

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/ILSDI/Services.pm
t/db_dependent/ILSDI_Services.t