Bug 18736: Use rounding syspref to determine correct prices in calculations
authorNick Clemens <nick@bywatersolutions.com>
Thu, 28 Dec 2017 15:15:47 +0000 (15:15 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 25 Mar 2019 14:29:28 +0000 (14:29 +0000)
commita968e5f59c8cfb0e996d978c22bfd1d395ad6258
treeb945ed5c5d8c11e8469532d3f39431d59a501757
parenta220d9e979e746ce1920e1f2aec475d32c792902
Bug 18736: Use rounding syspref to determine correct prices in calculations

To test:
Place an order (no tax just for simplicity)
 listprice/rrp = 16.99
 discount = 42%
 quantity = 8
 estimated calculated at 9.85
 but order total is 78.83, but 8 times 9.85 = 78.80
Apply patches, set OrderPriceRounding syspref to 'Nearest cent'
Not order total is now as expected
View ordered.pl and confirm values are correct
Complete order, view invoice and confirm values
View spent.pl and confirm values
Go through acquisitions module and confirm prices throughout are
correct.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 7fe5f8cd2c2d1eddd2a835fb644c262cffcbd34c)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
12 files changed:
C4/Acquisition.pm
C4/Budgets.pm
Koha/pdfformat/layout3pages.pm
Koha/pdfformat/layout3pagesfr.pm
acqui/basket.pl
acqui/basketgroup.pl
acqui/invoice.pl
acqui/ordered.pl
acqui/parcel.pl
acqui/spent.pl
installer/data/mysql/atomicupdate/bug18736_add_rounding_syspref.perl
reports/orders_by_fund.pl