Bug 18976: Fix t/db_dependent/Auth.t cleanup
authorLari Taskula <lari.taskula@jns.fi>
Mon, 24 Jul 2017 13:43:18 +0000 (16:43 +0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 26 Jul 2017 17:36:34 +0000 (14:36 -0300)
commit99d18bf0f3f729261b6560f0dd3c5d757aba3a19
treed7642411e396a05a5db79a6a37aa8dec7aa0c8b2
parent139b66f65611cff0a2551662e0fd5c2e50b4c10f
Bug 18976: Fix t/db_dependent/Auth.t cleanup

Test t/db_dependent/Auth.t seems to have an ineffective test data cleanup.
Data generated by TestBuilder is left in borrowers, branches, categories,
sms_providers and sessions tables after the test.

To replicate:
1. Check the row count of borrowers, branches and categories tables
2. prove t/db_dependent/Auth.t
3. Repeat step 1
4. Observe borrowers the following tables have increased in row count:
   - borrowers
   - branches
   - categories
   - sessions
   - sms_providers

To test:
1. Before applying the patch, go through steps at "To replicate" plan
2. Apply patch
3. Go through steps at "To replicate" plan
4. Observe step 4 no longer applies and those tables have the same number of
   rows as before executing the test.

This issue has been happening in REST tests as well, and this solution is
directly copy-pasted from t/db_dependent/api/v1/cities.t

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
t/db_dependent/Auth.t