Bug 22536: Display problem in Holds to Pull report
authorOwen Leonard <oleonard@myacpl.org>
Tue, 19 Mar 2019 12:41:26 +0000 (12:41 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 1 Apr 2019 16:41:23 +0000 (16:41 +0000)
commit9116cba3506b1129ed4165734a18fb66b3b8191a
tree3f23ef4f3ebe236fe536e570708626093e93319e
parent3ade1f52cd4ef73e44997726f8de56d0a9cac810
Bug 22536: Display problem in Holds to Pull report

This patch modifies the display of several values in the holds to pull
report so that they can be displayed as lists instead of as chunks of
HTML generated in SQL.

This patch modifies the SQL in pendingreserves.pl so that values can be
formatted in the same way that holding branch is. The better long-term
solution is to remove SQL from pendingreserves.pl altogether, but this
is a quick fix.

This patch also makes a couple of minor markup changes to fix
validation.

To test, apply the patch and go to Circulation -> Holds to pull. To see
the changes the patch makes your holds to pull list should have titles
with multiple items at multiple branches, with call number, copy number,
and enumeration data. These values should all be displayed in bulleted
lists.

Signed-off-by: David Roberts <david.roberts@ptfs-europe.com>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 9a321c128fed457bf6d11d2ce7ee7edf7dd28004)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 38bbe82aa07aa9a1a3cc33e00b5b8e459eb28a30)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
circ/pendingreserves.pl
koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt