Bug 15823: Can still access patron discharge slip without having the syspref on
authorAleisha <aleishaamohia@hotmail.com>
Tue, 23 Feb 2016 04:06:30 +0000 (04:06 +0000)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Fri, 6 May 2016 04:20:48 +0000 (04:20 +0000)
commit853d3cfe4d76d6f847e4f30dca4d50d278951fd0
treee33278923982b2ea004c64d94f8cad3513d9aa1d
parent27db26c5b785e813c494c1c865b43da6c73c20e9
Bug 15823: Can still access patron discharge slip without having the syspref on

EDIT: Fix for OPAC side
EDIT: Comment 10
EDIT: Merge conflicts

To test:
1) Ensure syspref useDischarge is disabled
2) Go to /cgi-bin/koha/members/discharge.pl?borrowernumber=X&discharge=1
3) Validate that you are still able to generate a discharge slip for this patron
4) Apply patch and refresh page
5) Confirm that you are redirected to the circulation.pl page for the user and that an error message is there.
OPAC SIDE
6) Go to the OPAC
7) Go to /cgi-bin/koha/opac-discharge.pl
8) Confirm you get a message saying discharges are disabled
9) Go to /cgi-bin/koha/opac-discharge.pl?op=request
10) Confirm you see same message

Sponsored-by: Catalyst IT

Followed test plan, works as expected (both staff client and OPAC).
Re-tested, works OK.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
circ/circulation.pl
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt
members/discharge.pl