Bug 15774: Add additional fields to order baskets
authorJesse Weaver <jweaver@bywatersolutions.com>
Wed, 10 Feb 2016 19:29:06 +0000 (12:29 -0700)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 7 Mar 2019 20:37:05 +0000 (20:37 +0000)
commit84f83012295c90995db48775ff32f06b8d082581
treef08832e4643337ae5aa5dbef3749a6099e4d035d
parent9ff997eda7582dbb68d599ab1436b162dd1559da
Bug 15774: Add additional fields to order baskets

This also moves the admin page for additional fields for all tables to a
single common screen, and factors out display/input parsing logic.

Test plan:
  1. Create an additional field for a subscription (under Serials -> Add
     subscription fields).
  2. Apply patch.
  3. Visit Additional fields under administration, and verify that
     the field created above still shows under the list for the
     subscription table.
  4. Create at least four fields for aqbasket for each combination of
     searchable/not-searchable and with/without an authorized value.
  5. Create an order basket, and verify that all fields are visible and
     correctly save.
  6. Edit the basket, verifying that changes to these additional fields
     are saved.
  7. Add an order to the basket (contents are irrelevant).
  8. Go to advanced search within acquisitions.
  9. Verify that only the searchable fields show in the form, and that
     their contents may be searched.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
20 files changed:
C4/Acquisition.pm
Koha/AdditionalField.pm
acqui/basket.pl
acqui/basketheader.pl
acqui/histsearch.pl
admin/additional-fields.pl [moved from serials/add_fields.pl with 88% similarity]
koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-display.inc [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
koha-tmpl/intranet-tmpl/prog/en/includes/filter-orders.inc
koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketheader.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt [new file with mode: 0755]
koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt [deleted file]
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
serials/serials-search.pl
serials/subscription-add.pl