Bug 21270: "Not finding what you're looking for" displaying uselessly
authorBlou <philippe.blouin@inlibro.com>
Fri, 24 Aug 2018 15:46:54 +0000 (11:46 -0400)
committerHayley Mapley <hayleymapley@catalyst.net.nz>
Thu, 9 Jan 2020 23:40:54 +0000 (12:40 +1300)
commit7523e7f7fc033045f29fba24eed0f9b53bf09599
treeeeba7ed3b7639b9daa309dfd06a829a8bf6a9693
parentf1c2ed41491a334c3029f5f2079ea41127263669
Bug 21270: "Not finding what you're looking for" displaying uselessly

When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled.

Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user.

Just taunting them...

TEST:
0) Set IllModule to true, AnonSuggestions to false.
1) Without login, just to an OPAC search.  At the bottom will be a nice string laughing at your failed search
2) Apply the patch.
3) Problem at 1) is fixed.
4) Login to validate that ILL link now appear.
5) Modify combination of IllModule and AnonSuggestions to validate links appearing.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 489cfb4b19b72dc1b156b0a4fa38add79ee3f05b)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit c3c0a1228f134df0a5bc0a2f692310c3451a88b8)
Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt