Bug 12159: Fix getting extended patron attributes for circ-menu
authorJosef Moravec <josef.moravec@gmail.com>
Thu, 15 Mar 2018 13:12:55 +0000 (13:12 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 28 Mar 2019 13:05:22 +0000 (13:05 +0000)
commit4fe300dec1937a7dc739573bc502fc566a55587d
tree1f53cdfcf36da35a6bdc74ec26e198279909e766
parent100e1e758c622234d1a176b1cdb45def8443833f
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
    limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Removed Koha/Schema/Result/BorrowerAttribute.pm
[EDIT] Added missing semicolon on L114 in Koha/Patron/Attribute.pm

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
26 files changed:
Koha/Patron.pm
Koha/Patron/Attribute.pm
Koha/Patron/Attributes.pm
circ/circulation.pl
koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt
members/boraccount.pl
members/files.pl
members/housebound.pl
members/mancredit.pl
members/maninvoice.pl
members/member-flags.pl
members/member-password.pl
members/memberentry.pl
members/moremember.pl
members/notices.pl
members/pay.pl
members/paycollect.pl
members/purchase-suggestions.pl
members/readingrec.pl
members/routing-lists.pl
members/statistics.pl
reports/borrowers_stats.pl
tools/viewlog.pl