Bug 20811: (QA follow-up) Make the isbn check work
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 20 Jul 2018 09:21:11 +0000 (11:21 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 24 Sep 2018 13:04:12 +0000 (15:04 +0200)
commit4b7e5108ea3e221998b38a6b7eeab4475f50d4d5
tree48fed12b7d4e12ace0302e84267f3282f7dc3547
parentb4d9ed346ed193e7a72d48745ad26b55737bfa7d
Bug 20811: (QA follow-up) Make the isbn check work

The following code was never reached, since $isbn was not filled.
    if (!$biblionumber && $isbn_check && $isbn) {
        $sth_isbn->execute($isbn);
        ($biblionumber,$biblioitemnumber) = $sth_isbn->fetchrow;
    }
Solution: Fix the code with two $isbn declarations. Move the checkisbn
condition a level deeper.

Test plan:
Run misc/migration_tools/bulkmarcimport.pl -file bib726.utf8 --update -isbn
Since you do not match on biblionumber, the ISBN should match.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit a49a7f08d6dbaf992d70420dae744c75c2ad8aae)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 5094909140081b02c9688faa07fc630feab91f24)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 8989ceb93fd002b91257c370e1584cacae193678)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
misc/migration_tools/bulkmarcimport.pl